Fix loadjson failed because of sql params not match #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unidevel
commented
Oct 29, 2025
Comment on lines
+52
to
+54
| if len(rows) == 1 && rows[0].ColumnCount() <= 1 { | ||
| continue | ||
| } |
Author
There was a problem hiding this comment.
When data is empty, usually only has query_id, insert will fail
unidevel
commented
Oct 29, 2025
Comment on lines
+57
to
+61
| placeholders := strings.Repeat("?,", row.ColumnCount()) | ||
| // Get rid of the trailing comma. | ||
| placeholders = placeholders[:len(placeholders)-1] | ||
| sqlStmt := fmt.Sprintf("INSERT INTO %s (%s) VALUES (%s)", | ||
| table, strings.Join(row.ColumnNames, ","), placeholders) |
Author
There was a problem hiding this comment.
This fixes cmd loadjson with the sample data
$ ./pbench_darwin_arm64 loadjson -n test --mysql ./mysql.conf -o ./test ./cmd/loadjson/20240422_013209_00111_k6ve9_shows_schema.json
{"level":"info","output_path":"test/test","time":"2025-10-29T21:58:11Z","message":"output directory"}
{"level":"info","log_path":"test/test/loadjson.log","time":"2025-10-29T21:58:11Z","message":"log file will be saved to this path"}
{"level":"info","parallelism":16,"time":"2025-10-29T21:58:11Z"}
{"level":"info","path":"./cmd/loadjson/20240422_013209_00111_k6ve9_shows_schema.json","time":"2025-10-29T21:58:11Z","message":"start to process file"}
{"level":"error","error":"sql: expected 37 arguments, got 38","path":"./cmd/loadjson/20240422_013209_00111_k6ve9_shows_schema.json","time":"2025-10-29T21:58:12Z","message":"failed to insert event listener record"}
{"level":"info","file_loaded":0,"time":"2025-10-29T21:58:12Z"}
Collaborator
There was a problem hiding this comment.
How can this happen? I don't understand
Author
There was a problem hiding this comment.
the rows is an array of operator stats, when it extract the rows, the first row has 37 column with 37 values, and some of the other rows has 38 columns with 38 values, but the statement is created by the first row, that makes the values not matching for some of the other rows which have 38 columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: